Re enable problem-matcher (#25)

Co-authored-by: Joakim Sørensen <hi@ludeeus.dev>

.github/problem-matcher.json

@@ -0,0 +1,22 @@
+{
+    "problemMatcher": [
+      {
+        "owner": "shellcheck",
+        "pattern": [
+          {
+              "regexp": "^In\\s(.+)\\sline\\s(\\d+):$",
+              "file": 1,
+              "line": 2
+          },
+          {
+            "regexp": ".*"
+          },
+          {
+              "regexp": "(SC\\d+):\\s(.+)$",
+              "code": 1,
+              "message": 2
+          }
+      ]
+      }
+    ]
+  }

.github/workflows/ShellCheck.yml

@@ -5,8 +5,10 @@ jobs:
     name: ShellCheck
     runs-on: ubuntu-latest
     steps:
+
     - name: Checkout
-      uses: actions/checkout@master
+      uses: actions/checkout@v2
+
     - name: Run ShellCheck
       uses: ./
       with:

Dockerfile

@@ -3,4 +3,6 @@ FROM alpine:3.12.0
 RUN apk add --no-cache shellcheck bash
 
 COPY runaction /action/runaction
+COPY .github/problem-matcher.json /problem-matcher.json
+
 ENTRYPOINT ["bash", "/action/runaction"]

README.md

@@ -17,7 +17,7 @@ jobs:
     name: Shellcheck
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@master
+    - uses: actions/checkout@v2
     - name: Run ShellCheck
       uses: ludeeus/action-shellcheck@master
 ```

runaction

@@ -1,5 +1,11 @@
 #!/bin/bash
 
+## Enable problem matcher
+cp /problem-matcher.json ./problem-matcher.json
+
+echo "::add-matcher::problem-matcher.json"
+
+## Run action
 cd "$GITHUB_WORKSPACE" || exit 1
 
 declare statuscode
@@ -8,6 +14,7 @@ declare -a excludes
 declare -a tmp
 
 statuscode=0
+shebangregex="^#! */[^ ]*/(env *)?[abkz]*sh"
 
 excludes+=( ! -path *./.git/* )
 excludes+=( ! -path *.go )
@@ -23,34 +30,38 @@ readarray -d '' filepaths < <(find . -type f "${excludes[@]}" \
     '(' \
     \
     -name '*.bash' \
-    -o -path '*/.bash*' \
-    -o -path '*/bash*' \
+    -o -name '.bashrc' \
+    -o -name 'bashrc' \
+    -o -name '.bash_aliases' \
+    -o -name '.bash_completion' \
+    -o -name '.bash_login' \
+    -o -name '.bash_logout' \
+    -o -name '.bash_profile' \
+    -o -name 'bash_profile' \
     -o -name '*.ksh' \
-    -o -name 'ksh*' \
-    -o -path '*/.ksh*' \
-    -o -path '*/ksh*' \
     -o -name 'suid_profile' \
     -o -name '*.zsh' \
-    -o -name '.zlogin*' \
-    -o -name 'zlogin*' \
-    -o -name '.zlogout*' \
-    -o -name 'zlogout*' \
-    -o -name '.zprofile*' \
-    -o -name 'zprofile*' \
-    -o -path '*/.zsh*' \
-    -o -path '*/zsh*' \
+    -o -name '.zlogin' \
+    -o -name 'zlogin' \
+    -o -name '.zlogout' \
+    -o -name 'zlogout' \
+    -o -name '.zprofile' \
+    -o -name 'zprofile' \
+    -o -name '.zsenv' \
+    -o -name 'zsenv' \
+    -o -name '.zshrc' \
+    -o -name 'zshrc' \
     -o -name '*.sh' \
-    -o -path '*/.profile*' \
-    -o -path '*/.shlib*' \
-    -o -path '*/shlib*' \
+    -o -path '*/.profile' \
+    -o -path '*/profile' \
+    -o -name '*.shlib' \
        ')'\
     \
     -print0)
 
-
 readarray -d '' tmp < <(find . "${excludes[@]}" -type f ! -name '*.*' -perm /111  -print0)
 for file in "${tmp[@]}"; do
-    head -n1 "$file" | grep -Eqs "^#! */[^ ]*/[abkz]*sh" || continue
+    head -n1 "$file" | grep -Eqs "$shebangregex" || continue
     filepaths+=("$file")
 done
 

testfiles/bashfile.c

@@ -0,0 +1,6 @@
+/* C code test file
+ * file that should not be matched for shellcheck runs
+ */
+int main(void) {
+    return 0;
+}

testfiles/ignore/ignore.sh

@@ -1,3 +1,5 @@
 #!/bin/sh
 
-echo $test
+echo $test $test
+
+echo $test2