matrix-docker-ansible-deploy/roles/matrix-postgres/tasks/util/create_additional_databases...

---

# TODO - we should ensure matrix-postgres.service is started.
# .. and that if we had just started it, we've given it ample time to initialize,
# before we attempt to run queries against it.

- name: Create additional Postgers user and database
  include_tasks: "{{ role_path }}/tasks/util/create_additional_database.yml"
  with_items: "{{ matrix_postgres_additional_databases }}"
  loop_control:
    loop_var: additional_db
  # Suppress logging to avoid dumping the credentials to the shell
  no_log: true
Relocate Postgres additional database creation logic Moving it above the "uninstalling" set of tasks is better. Extracting it out to another file at the same time, for readability, especially given that it will probably have to become more complex in the future (potentially installing `jq`, etc.) 4 years ago			`---`
Prevent weird loop error > Invalid data passed to 'loop', it requires a list, got this instead: matrix_postgres_additional_databases. Hint: If you passed a list/dict of just one element, try adding wantlist=True to your lookup invocation or use q/query instead of lookup. Well, or working around it, as I've done in this commit (which seems more sane than `wantlist=True` stuff). 4 years ago
Do not use the postgresql_user/postgresql_db modules While these modules are really nice and helpful, we can't use them for at least 2 reasons: - for us, Postgres runs in a container on a private Docker network (`--network=matrix`) without usually being exposed to the host. These modules execute on the host so they won't be able to reach it. - these modules require `psycopg2`, so we need to install it before using it. This might or might not be its own can of worms. 4 years ago			`# TODO - we should ensure matrix-postgres.service is started.`
			`# .. and that if we had just started it, we've given it ample time to initialize,`
			`# before we attempt to run queries against it.`
Relocate Postgres additional database creation logic Moving it above the "uninstalling" set of tasks is better. Extracting it out to another file at the same time, for readability, especially given that it will probably have to become more complex in the future (potentially installing `jq`, etc.) 4 years ago
Do not use the postgresql_user/postgresql_db modules While these modules are really nice and helpful, we can't use them for at least 2 reasons: - for us, Postgres runs in a container on a private Docker network (`--network=matrix`) without usually being exposed to the host. These modules execute on the host so they won't be able to reach it. - these modules require `psycopg2`, so we need to install it before using it. This might or might not be its own can of worms. 4 years ago			`- name: Create additional Postgers user and database`
			`include_tasks: "{{ role_path }}/tasks/util/create_additional_database.yml"`
			`with_items: "{{ matrix_postgres_additional_databases }}"`
			`loop_control:`
			`loop_var: additional_db`
			`# Suppress logging to avoid dumping the credentials to the shell`
			`no_log: true`