From 0641106370aed272e16cecaf2cf17754d30eb6c6 Mon Sep 17 00:00:00 2001
From: Slavi Pantaleev <slavi@devture.com>
Date: Sun, 13 Dec 2020 21:43:53 +0200
Subject: [PATCH] Allow username of additional Postgres databases to be
 different

We'll most likely use one that matches the database name, but
it's better to have it configurable.
---
 group_vars/matrix_servers                       | 17 ++++++++++++++++-
 roles/matrix-postgres/defaults/main.yml         |  6 ++++--
 .../tasks/util/create_additional_databases.yml  |  4 ++--
 3 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/group_vars/matrix_servers b/group_vars/matrix_servers
index 8a099275..f131ab9e 100755
--- a/group_vars/matrix_servers
+++ b/group_vars/matrix_servers
@@ -893,62 +893,77 @@ matrix_postgres_additional_databases: |
   {{
     ([{
       name: 'matrix_appservice_discord',
+      username: 'matrix_appservice_discord',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'app_discord.db.secret') | string
     }] if matrix_appservice_discord_enabled else [])
     + ([{
       name: 'matrix_appservice_slack'
+      username: 'matrix_appservice_slack',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'app_slack.db.secret') | string
     }] if matrix_appservice_slack_enabled else [])
     + ([{
       name: 'matrix_appservice_irc'
+      username: 'matrix_appservice_irc',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'app_irc.db.secret') | string
     }] if matrix_appservice_irc_enabled else [])
     + ([{
-      name: 'mautrix-bridge-facebook'
+      name: 'mautrix_bridge_facebook'
+      username: 'mautrix_bridge_facebook',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'mautrix_facebook.db.secret') | string
     }] if matrix_mautrix_facebook_enabled else [])
     + ([{
       name: 'mautrix_bridge_hangouts'
+      username: 'mautrix_bridge_hangouts',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'mautrix_hangouts.db.secret') | string
     }] if matrix_mautrix_hangouts_enabled else [])
     + ([{
       name: 'mautrix_bridge_telegram'
+      username: 'mautrix_bridge_telegram',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'mautrix_telegram.db.secret') | string
     }] if matrix_mautrix_telegram_enabled else [])
     + ([{
       name: 'mautrix_bridge_whatsapp'
+      username: 'mautrix_bridge_whatsapp',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'mautrix_whatsapp.db.secret') | string
     }] if matrix_mautrix_whatsapp_enabled else [])
     + ([{
       name: 'matrix_bridge_sms'
+      username: 'matrix_bridge_sms',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'bridge_sms.db.secret') | string
     }] if matrix_sms_bridge_enabled else [])
     + ([{
       name: 'matrix_puppet_skype'
+      username: 'matrix_puppet_skype',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'mx_skype.db.secret') | string
     }] if matrix_mx_puppet_skype_enabled else [])
     + ([{
       name: 'matrix_puppet_slack'
+      username: 'matrix_puppet_slack',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'mx_slack.db.secret') | string
     }] if matrix_mx_puppet_slack_enabled else [])
     + ([{
       name: 'matrix_puppet_twitter'
+      username: 'matrix_puppet_twitter',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'mx_twitter.db.secret') | string
     }] if matrix_mx_puppet_twitter_enabled else [])
     + ([{
       name: 'matrix_puppet_instagram'
+      username: 'matrix_puppet_instagram',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'mx_insta.db.secret') | string
     ] if matrix_mx_puppet_instagram_enabled else [])
     + ([{
       name: 'matrix_puppet_discord'
+      username: 'matrix_puppet_discord',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'mx_puppet.db.secret') | string
     }] if matrix_mx_puppet_discord_enabled else [])
     + ([{
       name: 'matrix_puppet_steam'
+      username: 'matrix_puppet_steam',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'mx_steam.db.secret') | string
     }] if matrix_mx_puppet_steam_enabled else [])
     + ([{
       name: 'matrix_dimension'
+      username: 'matrix_dimension',
       pass: matrix_synapse_macaroon_secret_key | password_hash('sha512', 'dimension.db.secret') | string
     }] if matrix_dimension_enabled else [])
   }}
diff --git a/roles/matrix-postgres/defaults/main.yml b/roles/matrix-postgres/defaults/main.yml
index 548cac15..2645d4b0 100644
--- a/roles/matrix-postgres/defaults/main.yml
+++ b/roles/matrix-postgres/defaults/main.yml
@@ -36,7 +36,9 @@ matrix_postgres_container_postgres_bind_port: ""
 # Example:
 # matrix_postgres_additional_databases:
 #   - name: matrix_appservice_discord
-#     pass: some-password
+#     username: matrix_appservice_discord
+#     pass: some_password
 #   - name: matrix_appservice_slack
-#     pass: some-password
+#     username: matrix_appservice_slack
+#     pass: some_password
 matrix_postgres_additional_databases: []
diff --git a/roles/matrix-postgres/tasks/util/create_additional_databases.yml b/roles/matrix-postgres/tasks/util/create_additional_databases.yml
index ec37ea63..0532c99d 100644
--- a/roles/matrix-postgres/tasks/util/create_additional_databases.yml
+++ b/roles/matrix-postgres/tasks/util/create_additional_databases.yml
@@ -6,7 +6,7 @@
 
 - name: Create additional users in postgres
   postgresql_user:
-    name: "{{ item.name }}"
+    name: "{{ item.username }}"
     password: "{{ item.pass }}"
     login_host: "{{ matrix_postgres_container_ip.stdout }}"
     login_port: 5432
@@ -18,7 +18,7 @@
 - name: Create additional users in postgres
   postgresql_db:
     name: "{{ item.name }}"
-    owner: "{{ item.name }}"
+    owner: "{{ item.username }}"
     lc_ctype: 'C'
     lc_collate: 'C'
     login_host: "{{ matrix_postgres_container_ip.stdout }}"